Repository navigation
test(phel): drop stale :phel override for (keyword "a/b/c") splitting - #22
Merged
JesusValeraDev merged 1 commit intoJul 17, 2026
Merged
JesusValeraDev merged 1 commit into
JesusValeraDev merged 1 commit into
Conversation
Phel now splits a slashed keyword string on the first / like JVM Clojure (phel-lang/phel-lang#2741), so simple-ident?/simple-keyword? follow the :default expectation.
JesusValeraDev
added a commit
to phel-lang/phel-lang
that referenced
this pull request
Jul 17, 2026
Picks up phel-lang/clojure-test-suite#22, which drops the stale :phel override for (keyword "a/b/c") in simple-ident?/simple-keyword?. Related to #2741
JesusValeraDev
added a commit
to phel-lang/phel-lang
that referenced
this pull request
Jul 17, 2026
* fix(lang): parse namespace in keyword string constructor
Split (keyword s) on the first / into namespace and name, matching
symbol and Clojure. Add Keyword::createForNamespace for verbatim
construction (two-arg keyword, symbol input, emitter round-trip) and
key the intern pool by namespace and name separately so (nil, "a/b")
and ("a", "b") no longer collide.
Related to #2741
* ref(compiler): polish keyword literal emission after #2741
Related to #2741
* chore(ci): bump clojure-test-suite pin for keyword ns splitting
Picks up phel-lang/clojure-test-suite#22, which drops the stale
:phel override for (keyword "a/b/c") in simple-ident?/simple-keyword?.
Related to #2741
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phel now splits a slashed keyword string on the first
/like JVM Clojure (phel-lang/phel-lang#2741, fixed in phel-lang/phel-lang#2762), sosimple-ident?/simple-keyword?on(keyword "a/b/c")follow the:default falseexpectation instead of the old lenient:phel truebranch.Verified locally against the phel-lang PR branch: 5591/5591 suite tests pass.